hyprctl: link to much less libraries #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes hyprctl start significantly faster. $ time for ((i=0; i<1000; i++)); do hyprctl/hyprctl -j activewindow >/dev/null; done Before: 12.269 s (about 12.3 ms/execution) After: 2.142 s (about 2.1 ms/execution)
adomixaszvers
added a commit
to adomixaszvers/dotfiles-nix
that referenced
this pull request
Oct 19, 2024
backported from hyprwm/Hyprland#7212
adomixaszvers
added a commit
to adomixaszvers/dotfiles-nix
that referenced
this pull request
Oct 19, 2024
backported from hyprwm/Hyprland#7212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed by latency caused by implementing some operations in shell scripts; particularly if the shell script needed to read some status using hyprctl and then decide to do more hyprctl executions.
Describe your PR, what does it fix/add?
This makes hyprctl start significantly faster.
$ time for ((i=0; i<1000; i++)); do hyprctl/hyprctl -j activewindow >/dev/null; doneBefore: 12.269 s (about 12.3 ms/execution)
After: 2.142 s (about 2.1 ms/execution)
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
The one thing I don't like is how this adds another mention (and version constraint) of
hyprutils>=0.2.1in the top levelCMakeLists.txt. I don't understand CMake well enough to tell if thedepscould be made to somehow inherithyprctl_deps.Is it ready for merging, or does it need work?
I believe it is ready to merge as is, unless you know a way to only mention hyprutils once :)